Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable cache #2568

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Disable cache #2568

wants to merge 2 commits into from

Conversation

stwiname
Copy link
Collaborator

@stwiname stwiname commented Oct 6, 2024

Description

Provides an option to disable the cache for the store.

Details

  • Define/update and interfaces to provide abstractions to the Model, Metadata and POI interfaces as well as the StoreCacheService
  • Implement non-cache versions of abstracted interfaces
  • Update cache classes to match any interface changes
  • Create db transactions for when cache is not used

TODOs

  • Fix remaining build errors and update interfaces to abstract between flushing cache/managing db transaction
  • Implement flag to change the option and inject the appropriate class (StoreCacheService or PlainStoreModelService)
  • Implement tests and update existing tests
  • Improve code reuse by deduplicating any functionality between cache and non-cache models

Fixes #2563

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to disable the cache
1 participant